Thread (1 message) 1 message, 1 author, 2017-09-27

Re: [PATCH] IB/ipoib: Enable pkey and device name decoupling

From: Doug Ledford <hidden>
Date: 2017-09-27 14:14:17

Possibly related (same subject, not in this thread)

On Wed, 2017-09-27 at 12:32 +0300, Yuval Shaia wrote:
+       /*
+        * (1) buf_after_dot check above makes it valid hexdigit
.XXXX format
+        *
+        * Now verify if buf_before_dot is a valid net device name -
+        * (if it is not, then we are not in disallowed namespace)
+        */
+       if (__dev_get_by_name(&init_net, buf_before_dot) == NULL)
+               return false;
This is wrong.  We don't use &init_net in ipoib any more, we are
namespace aware, so your patch must be namespace aware too.

-- 
Doug Ledford [off-list ref]
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help