Re: [PATCH v1 11/11] IB/rxe: Handle NETDEV_CHANGE events

Hi Andrew,

[auto build test ERROR on rdma/master]
[also build test ERROR on v4.13-rc6 next-20170825]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Andrew-Boyer/IB-rxe-Bug-fixes/20170828-060737
base:   https://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma.git master
config: i386-randconfig-x001-201735 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/infiniband//sw/rxe/rxe_net.c: In function 'rxe_notify':

quoted

drivers/infiniband//sw/rxe/rxe_net.c:656:21: error: 'port_num' undeclared (first use in this function)

       rxe_port_up(rxe, port_num);
                        ^~~~~~~~
   drivers/infiniband//sw/rxe/rxe_net.c:656:21: note: each undeclared identifier is reported only once for each function it appears in

quoted

drivers/infiniband//sw/rxe/rxe_net.c:656:4: error: too many arguments to function 'rxe_port_up'

       rxe_port_up(rxe, port_num);
       ^~~~~~~~~~~
   drivers/infiniband//sw/rxe/rxe_net.c:604:6: note: declared here
    void rxe_port_up(struct rxe_dev *rxe)
         ^~~~~~~~~~~

quoted

drivers/infiniband//sw/rxe/rxe_net.c:658:4: error: too many arguments to function 'rxe_port_down'

       rxe_port_down(rxe, port_num);
       ^~~~~~~~~~~~~
   drivers/infiniband//sw/rxe/rxe_net.c:617:6: note: declared here
    void rxe_port_down(struct rxe_dev *rxe)
         ^~~~~~~~~~~~~

vim +/port_num +656 drivers/infiniband//sw/rxe/rxe_net.c

   628	
   629	static int rxe_notify(struct notifier_block *not_blk,
   630			      unsigned long event,
   631			      void *arg)
   632	{
   633		struct net_device *ndev = netdev_notifier_info_to_dev(arg);
   634		struct rxe_dev *rxe = net_to_rxe(ndev);
   635	
   636		if (!rxe)
   637			goto out;
   638	
   639		switch (event) {
   640		case NETDEV_UNREGISTER:
   641			list_del(&rxe->list);
   642			rxe_remove(rxe);
   643			break;
   644		case NETDEV_UP:
   645			rxe_port_up(rxe);
   646			break;
   647		case NETDEV_DOWN:
   648			rxe_port_down(rxe);
   649			break;
   650		case NETDEV_CHANGEMTU:
   651			pr_info("%s changed mtu to %d\n", ndev->name, ndev->mtu);
   652			rxe_set_mtu(rxe, ndev->mtu);
   653			break;
   654		case NETDEV_CHANGE:
   655			if (netif_running(ndev) && netif_carrier_ok(ndev))
 > 656				rxe_port_up(rxe, port_num);
   657			else
 > 658				rxe_port_down(rxe, port_num);
   659			break;
   660		case NETDEV_REBOOT:
   661		case NETDEV_GOING_DOWN:
   662		case NETDEV_CHANGEADDR:
   663		case NETDEV_CHANGENAME:
   664		case NETDEV_FEAT_CHANGE:
   665		default:
   666			pr_info("ignoring netdev event = %ld for %s\n",
   667				event, ndev->name);
   668			break;
   669		}
   670	out:
   671		return NOTIFY_OK;
   672	}
   673	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation