Re: [PATCH] rdma-core: define link speed and link width enums

On 05/08/2017 09:54 AM, Leon Romanovsky wrote:

On Mon, May 08, 2017 at 09:44:17AM -0400, Devesh Sharma wrote:

quoted

Currently application either need to define its own enum
values for link-speed and link-width or use hard coded
values. This patch inharits the enums from kernel space
ib_verbs.h and puts into verbs.h for ease of programming.

Signed-off-by: Devesh Sharma <devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
---
 libibverbs/examples/devinfo.c | 22 ++++++++++++----------
 libibverbs/verbs.h            | 18 ++++++++++++++++++
 2 files changed, 30 insertions(+), 10 deletions(-)

I think the better approach will be move these defines from
include/rdma/ib_verbs.h to include/uapi/rdma/ib_user_verbs.h
and reuse ib_user_verbs.h file directly in libibverbs.

I agree on this. Please put this stuff in the uapi header file and include that in user space.

-Denny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html