Re: [patch] net/mlx4: && vs & typo
From: Tariq Toukan <hidden>
Date: 2017-02-28 18:28:53
Also in:
kernel-janitors, netdev
On 28/02/2017 2:02 PM, Dan Carpenter wrote:
Bitwise & was obviously intended here.
Sure! Thanks for your patch.
quoted hunk ↗ jump to hunk
Fixes: 745d8ae4622c ("net/mlx4: Spoofcheck and zero MAC can't coexist") Signed-off-by: Dan Carpenter <redacted> --- Applies to net.git.diff --git a/include/linux/mlx4/driver.h b/include/linux/mlx4/driver.h index e965e5090d96..a858bcb6220b 100644 --- a/include/linux/mlx4/driver.h +++ b/include/linux/mlx4/driver.h@@ -109,7 +109,7 @@ static inline void mlx4_u64_to_mac(u8 *addr, u64 mac) int i; for (i = ETH_ALEN; i > 0; i--) { - addr[i - 1] = mac && 0xFF; + addr[i - 1] = mac & 0xFF; mac >>= 8; } } --To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Tariq Toukan <redacted>