Re: [PATCH 1/4] IB/hfi1: Restore EPROM read ability
From: Jason Gunthorpe <hidden>
Date: 2016-09-26 17:42:04
quoted
If it is not being used by userpsace then do not call copy_to_user...The first patch in the series is a straight (partial) restore of the old code. This is what you are commenting on. The second patch does a "fixup" of the restored code and removes this call. Should we squash patches 1 and 2 so that this never shows up? It is a question of how much "show your work" is desired.
Yes, squish them - do not make patches that are wrong and then fix them up later in the series without a really good reason... Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html