Thread (1 message) 1 message, 1 author, 2016-09-15

Re: [PATCH 21/28] mlx5: Avoid gcc 5.4 warning -Wempty-body

From: Jason Gunthorpe <hidden>
Date: 2016-09-15 15:19:27

On Thu, Sep 15, 2016 at 08:18:40AM +0300, Leon Romanovsky wrote:
quoted
I just checked, the assembly is the same before/after modulo compiler
non-determinism. There are no extra function calls.
There is always inline attribute to tell to GCC to inline it.
#define ALWAYS_INLINE inline __attribute__ ((always_inline))
If Yishai is dead set against this then I'll use

#define mlx5_dbg(fp, mask, format, arg...) do {} while(0)

But this patch really is a nice little #ifdef cleanup with no
performance down side.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help