Re: [PATCH 02/28] Include pthreads in the provider libraries
From: Yishai Hadas <hidden>
Date: 2016-09-14 16:27:52
On 9/14/2016 7:01 PM, Jason Gunthorpe wrote:
On Wed, Sep 14, 2016 at 06:15:45PM +0300, Yishai Hadas wrote:quoted
On 9/6/2016 12:07 AM, Jason Gunthorpe wrote:quoted
It is a mistake to not explicitly link to the libraries required. Not linking causes the symbols to drop the symbol version which could cause runtime problems down the road if pthreads ever goes through another symbol version change.Where in this patch the provider links explicitly with pthreads as you pointed that should be done ? can see only a check that pthread exists and has the pthread_mutex_init symbol.AC_CHECK_LIB adds the library to the link line as well.
Just verified, this is correct, will take into libmlx4/libmlx5. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html