Re: [PATCH v3 12/15] IB/pvrdma: Add the main driver module for PVRDMA

On Thu, Sep 08, 2016 at 08:25:55 -0700, Yuval Shaia wrote:

On Wed, Sep 07, 2016 at 07:41:42PM +0000, Adit Ranadive wrote:

quoted

...

quoted

quoted

+
+	if (pdev_net->vendor != PCI_VENDOR_ID_VMWARE ||
+	    pdev_net->device != PCI_DEVICE_ID_VMWARE_VMXNET3) {
+		dev_err(&pdev->dev, "failed to find paired vmxnet3

device\n");

quoted

+		pci_dev_put(pdev_net);
+		ret = -ENODEV;
+		goto err_free_cq_ring;
+	}

Any reason to enforce to this netdev only?

Yes, we expose our device to the guest as a dual function PCIe device with
Ethernet (VMXNet3) and RDMA (PVRDMA) capabilities. We use the

VMXNet3

quoted

netdev to find the Ethernet properties required in the PVRDMA module.

So on a guest with 4 VMWare RDMA devices i will have an extra 4 VMXNet3
devices.
And so on.

I wouldn't consider them as extra. They are just part of the PVRDMA device
really. It's just that they aren't integrated with the PVRDMA device in the PCI
space.
Also, wouldn't it be the same if you had 4 RoCE cards on a Linux box?
You would have 4 ethernet devices as well ..
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html