Re: [PATCH v4] nvmet-rdma: Correctly handle RDMA device hot removal
From: Christoph Hellwig <hidden>
Date: 2016-08-04 11:50:05
Also in:
linux-nvme
From: Christoph Hellwig <hidden>
Date: 2016-08-04 11:50:05
Also in:
linux-nvme
On Wed, Aug 03, 2016 at 04:19:53PM +0300, Sagi Grimberg wrote:
When configuring a device attached listener, we may see device removal events. In this case we return a non-zero return code from the cm event handler which implicitly destroys the cm_id. It is possible that in the future the user will remove this listener and by that trigger a second call to rdma_destroy_id on an already destroyed cm_id -> BUG. In addition, when a queue bound (active session) cm_id generates a DEVICE_REMOVAL event we must guarantee all resources are cleaned up by the time we return from the event handler. Introduce nvmet_rdma_device_removal which addresses (or at least attempts to) both scenarios. Signed-off-by: Sagi Grimberg <redacted>
Looks fine, Reviewed-by: Christoph Hellwig <redacted> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html