Thread (8 messages) 8 messages, 3 authors, 2016-08-04
STALE3615d

Re: [PATCH] nvmet-rdma: Don't use the inline buffer in order to avoid allocation for small reads

From: Christoph Hellwig <hidden>
Date: 2016-08-02 12:50:42
Also in: linux-nvme

On Mon, Aug 01, 2016 at 11:36:39AM +0300, Sagi Grimberg wrote:
Under extreme conditions this might cause data corruptions. By doing that
we we repost the buffer and then post this buffer for the device to send.
If we happen to use shared receive queues the device might write to the
buffer before it sends it (there is no ordering between send and recv
queues). Without SRQs we probably won't get that if the host doesn't
mis-behave and send more than we allowed it, but relying on that is not
really a good idea.
Pitty - it seems so wasteful not being able to use these buffers for
anything that isn't an inline write.  I fully agree on the SRQ case,
but I think we should offer it for the non-SRP case.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help