On 08/01/16 04:15, Christoph Hellwig wrote:

This looks reasonable to me, but a little question below:

quoted

@@ -1442,7 +1491,8 @@ static void nvmet_rdma_remove_port(struct nvmet_port *port)
 {
 	struct rdma_cm_id *cm_id = port->priv;

-	rdma_destroy_id(cm_id);
+	if (cm_id)
+		rdma_destroy_id(cm_id);
 }

How is ->remove_port synchronized vs the RDMA/CM event handler?

rdma_destroy_id() waits until active RDMA/CM callbacks have finished. Is 
that sufficient or is further synchronization needed?

Bart.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html