Re: [PATCH libibverbs 2/3] Add support for TCP segmentation offload (TSO)

On 8/17/2016 5:35 PM, Sagi Grimberg wrote:

quoted

diff --git a/include/infiniband/verbs.h b/include/infiniband/verbs.h
index ccf1d51..87e4332 100644
--- a/include/infiniband/verbs.h
+++ b/include/infiniband/verbs.h

@@ -209,6 +209,13 @@ enum ibv_odp_general_caps {
     IBV_ODP_SUPPORT = 1 << 0,
 };

+#define ibv_is_qpt_supported(caps, qpt) ((caps) & (1 << (qpt)))

This looks useful, but not directly related to this patch. Would
be better to add it in a stand-alone patch (even if its a one-liner).

It's used internally by that patch, look at print_tso_caps. Better stay 
with that.

Otherwise looks good,

Reviewed-by: Sagi Grimberg <redacted>

Thanks Sagi for your review.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html