Re: [PATCH] IB/hfi1: Fetch monitor values on-demand for CableInfo query

On Wed, Aug 10, 2016 at 01:35:50AM -0400, ira.weiny wrote:

On Tue, Aug 09, 2016 at 08:58:01PM +0300, Leon Romanovsky wrote:

quoted

On Tue, Aug 09, 2016 at 11:17:18AM -0400, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:

quoted

From: Easwar Hariharan <redacted>

The monitor values from bytes 22 through 81 of the QSFP memory space
(SFF 8636) are dynamic and serving them out of the QSFP memory cache
maintained by the driver provides stale data to the CableInfo SMA query.
This patch refreshes the dynamic values from the QSFP memory on request
and overwrites the stale data from the cache for the overlap between the
requested range and the monitor range.

Ira,
On all your patches, you have double line between commit message and
tags.

Does this cause a problem?

Problem - no, inconvenience - yes.
It doesn't look pretty in git history.

Ira

quoted

quoted

Reviewed-by: Jubin John <redacted>
Reviewed-by: Ira Weiny <redacted>
Signed-off-by: Easwar Hariharan <redacted>