Thread (1 message) 1 message, 1 author, 2016-07-05

Re: [PATCH for-next 2/2] IB/core: Support for CMA multicast join flags

From: Or Gerlitz <hidden>
Date: 2016-07-05 12:44:04

On Tue, Jul 5, 2016 at 1:45 PM, Leon Romanovsky [off-list ref] wrote:
On Mon, Jul 04, 2016 at 03:40:10PM +0300, Or Gerlitz wrote:
quoted
+++ b/include/uapi/rdma/rdma_user_cm.h
@@ -244,12 +244,19 @@ struct rdma_ucm_join_ip_mcast {
  __u32 id;
 };

 struct rdma_ucm_join_mcast {
  __u64 response; /* rdma_ucma_create_id_resp */
  __u64 uid;
  __u32 id;
  __u16 addr_size;
- __u16 reserved;
+ __u16 join_flags;
  struct sockaddr_storage addr;
 };
The main issue here that new code is using this struct and new field while the old
code uses reserved field.
If per your judgment, in this case we can't break things for UAPI vs
non-UAPI, let have an exception and move on :)

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help