RE: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver
From: Steve Wise <hidden>
Date: 2016-06-14 15:23:16
Also in:
linux-block, linux-nvme, lkml
Subsystem:
nvm express target driver, the rest · Maintainers:
Christoph Hellwig, Sagi Grimberg, Chaitanya Kulkarni, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-07-08 · RE: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver · Steve Wise <hidden>
- 2016-07-06 · [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver · Christoph Hellwig <hch@lst.de>
- 2016-06-15 · Re: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver · Sagi Grimberg <hidden>
- 2016-06-14 · RE: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver · Hefty, Sean <hidden>
- 2016-06-14 · RE: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver · Steve Wise <hidden>
Eitherquoted
quoted
nvmet should reject and destroy the cm_id, or it should do neither and return non-zero to the RDMA_CM to reject/destroy.Can you just send a patch?Yes, I'll send it out in a separate email.
Before I do, what do you think of this (untested)?
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index b1c6e5b..6f0c335 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c@@ -1255,7 +1255,8 @@ static int nvmet_rdma_cm_handler(struct rdma_cm_id *cm_id, switch (event->event) { case RDMA_CM_EVENT_CONNECT_REQUEST: - ret = nvmet_rdma_queue_connect(cm_id, event); + if (nvmet_rdma_queue_connect(cm_id, event)) + rdma_destroy_id(cm_id); break; case RDMA_CM_EVENT_ESTABLISHED: nvmet_rdma_queue_established(queue); --
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html