Re: [PATCH 4/6] IB/core: Enhance ib_map_mr_sg()

----- Original Message -----

From: "Bart Van Assche" <redacted>
To: leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: "Doug Ledford" <redacted>, "Christoph Hellwig" <redacted>, "Sagi Grimberg" <redacted>,
"Laurence Oberman" [off-list ref], linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Or Gerlitz" [off-list ref]
Sent: Wednesday, May 11, 2016 11:22:29 AM
Subject: Re: [PATCH 4/6] IB/core: Enhance ib_map_mr_sg()

On 05/11/2016 12:54 AM, Leon Romanovsky wrote:

quoted

On Tue, May 10, 2016 at 05:14:57PM -0700, Bart Van Assche wrote:

quoted

The SRP initiator allows to set max_sectors to a value that exceeds
the largest amount of data that can be mapped at once with an mlx4
HCA using fast registration and a page size of 4 KB. Hence modify
ib_map_mr_sg() such that it can map partial sg-elements. If an
sg-element has been mapped partially, let the caller know
which fraction has been mapped by adjusting *sg_offset.

Signed-off-by: Bart Van Assche <redacted>
Cc: Christoph Hellwig <redacted>
Cc: Sagi Grimberg <redacted>
Cc: Laurence Oberman <redacted>
---

--- a/drivers/infiniband/hw/mlx5/mr.c
+++ b/drivers/infiniband/hw/mlx5/mr.c

@@ -1752,10 +1752,11 @@ static int
  mlx5_ib_sg_to_klms(struct mlx5_ib_mr *mr,
  		   struct scatterlist *sgl,
  		   unsigned short sg_nents,
-		   unsigned int sg_offset)
+		   unsigned int *sg_offset_p)
  {

I wonder on which tree are you basing?
In Linus (4.6-rc7) the function signature is different [1], the same
goes for my tree and Doug's for-4.7 branch [2].

Hello Leon,

Sorry that I hadn't mentioned this explicitly in the cover letter of
this patch series but this patch series is based on Christoph's generic
RDMA READ/WRITE API work.

Bart.

I chased that for a while too.:)
Landed up pulling the latest next, applying all of Christoph's 11 RDMA patches, then the first 11 of Barts and the latest 6.
I had to hand fix some stuff.
Kernel is building now for testing :)


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html