Re: [PATCH rdma-next V1 03/10] IB/core: Add subnet prefix to port info
From: Jason Gunthorpe <hidden>
Date: 2016-03-07 21:43:13
On Mon, Mar 07, 2016 at 11:08:53PM +0200, Eli Cohen wrote:
quoted hunk
+ err = ib_query_gid(ibdev, port, 0, &gid, NULL); + if (err) + return err; + + props->subnet_prefix = be64_to_cpu(gid.global.subnet_prefix);
Why not put this common pattern in ibv_query_port?
device->query_port(ibdev, port, ..);
if (props->subnet_prefix == 0) {
err = ib_query_gid(ibdev, port, 0, &gid, NULL);
if (err)
return err;
props->subnet_prefix = be64_to_cpu(gid.global.subnet_prefix);
}
quoted hunk
+++ b/include/rdma/ib_verbs.h@@ -509,6 +509,7 @@ struct ib_port_attr { u8 active_width; u8 active_speed; u8 phys_state; + u64 subnet_prefix; };
Can we put that at the start for better alignment? Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html