On 2/22/2013 3:23 PM, Jason Gunthorpe wrote:

On Fri, Feb 22, 2013 at 01:27:10PM -0500, Hal Rosenstock wrote:

quoted

quoted

+char * umad_class_str(uint8_t mgmt_class)
+{
+	switch (mgmt_class) {
+		case UMAD_CLASS_SUBN_LID_ROUTED:
+		case UMAD_CLASS_SUBN_DIRECTED_ROUTE:
+			return("Subn");

Doesn't this create a compiler warning? 

Not with my setup.

Is -Wall turned on? 

Yes but maybe it depends on gcc version.

The return type should be 'const char *' when returning strings from rodata.

Yes that would be better.

-- Hal

Jason

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html