Re: [PATCH] libibmad: Add ib_resolve_noderecord_via API

Hal,

ib_resolve_guid_via has timeout parameter but when it is getting called from ib_resolve_portid_str_via the value is specified as 0.


int ib_resolve_portid_str_via(ib_portid_t * portid, char *addr_str,
            enum MAD_DEST dest_type, ib_portid_t * sm_id,
            const struct ibmad_port *srcport)
{


  case IB_DEST_GUID:
    if (!(guid = strtoull(addr_str, 0, 0)))
      return -1;

    /* keep guid in portid? */
    return ib_resolve_guid_via(portid, &guid, sm_id, 0, srcport);


Thanks
Sarat


On 2/12/2013 3:19 PM, Hal Rosenstock wrote:

On 2/12/2013 6:03 PM, Sarat Kakarla wrote:

quoted

[SK] I wanted to make ib_resolve_noderecord_via look like ib_resolve_portid_str_via API which does not take any timeout parameter.

      I can pass '0' instead of MAD_DEF_TIMEOUT_MS, that's what passed as timeout to ib_resolve_guid_via function from  ib_resolve_portid_str_via function.

Are you looking at an older version of libibmad ? The upstream
ib_resolve_guid_via has timeout as second parameter as do other similar
calls to ib_resolve_smlid_via.

-- Hal

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html