Re: [PATCH libmlx4 1/8] Add raw packet QP support

On Fri, Sep 21, 2012 at 3:51 AM, Luick, Dean [off-list ref] wrote:

quoted

@@ -286,6 +286,10 @@ int mlx4_post_send(struct ibv_qp *ibqp, struct

ibv_send_wr *wr,
                      size += sizeof (struct mlx4_wqe_datagram_seg) / 16;
                      break;

+             case IBV_QPT_RAW_PACKET:
+                     /* For raw eth, the MLX4_WQE_CTRL_SOLICIT flag is used
+                      * to indicate that no icrc should be calculated */
+                     ctrl->srcrb_flags |= htonl(MLX4_WQE_CTRL_SOLICIT);
              default:
                      break;
              }

Add a break for the new case?  While the above code works as expected, it is inconsistent from what it was before, and could lead to problems if the default case starts doing something.

fair-enough, will fix
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html