Re: [PATCH] IB: new module params. cm_response_timeout, max_cm_retries

Le lundi 10 septembre 2012 à 19:11 +0000, Hefty, Sean a écrit :

quoted

Create two kernel parameters, in order to make variables configurable.
i.e. cma_cm_response_timeout for CM response timeout,
     and cma_max_cm_retries for the number of retries.

They can now be configured via command line for the kernel modules.
For example:
    # modprobe ib_srp cma_cm_response_timeout=30 cma_max_cm_retries=60

Rather than using a module parameter, I'd rather see this these values be
controlled through /proc/sys/net/rdma_cm, similar to how the rdma_ucm
handles max_backlog.

Having them is better so that one can try different values without
unloading the module.

It would also be great to have default parameters to be applied to all
CM loaded.: eg. rdma_cm / ib_srp default parameters should be made
available from ib_cm ?

For the rdma_cm, I also prefer something more generic.
CM retries is fine, but exposing wonky IB timeout (4.096 x 2^X us) to 
the user is less than ideal.

Sure, but which kind of approximation the kernel module is going to
do ? 

Regards.

-- 
Yann Droneaud
OPTEYA


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html