Thread (1 message) 1 message, 1 author, 2012-02-26

Re: [PATCH 2/6] IB/core: fix wrong display of rate in sysfs

From: Or Gerlitz <hidden>
Date: 2012-02-26 08:22:41

On 1/11/2012 9:45 PM, Or Gerlitz wrote:
Yep, this function is surely not programming state of the art.. 
however, except for SDR, the above line doing rate = rate * 
ib_width_enum_to_int(attr.active_width) would hold for all the speeds 
and all the widths (1X, 4X, 12X), if we just set rate (possibly as a 
string value) one time in each switch case, we would need to repeat 
that multiplication there... I'm okay with that, would you recommend 
to go that way? Roland any preference? Or. 
Hi Roland,

Could you please let me know if you want a change in this patch, or this 
fix can go in using the current form for 3.4?

thanks,

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help