Re: [opensm] [PATCH 1/2] Fix segfault corner case
From: Alex Netes <hidden>
Date: 2011-11-11 12:19:57
Hi Al, On 10:01 Thu 10 Nov , Albert Chu wrote:
quoted hunk
On rescan, data segment memory could be attempted to be freed by config file parsing code. Signed-off-by: Albert L. Chu <redacted> --- opensm/osm_subnet.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c index 554a950..c8a8add 100644 --- a/opensm/osm_subnet.c +++ b/opensm/osm_subnet.c@@ -1159,7 +1159,7 @@ int osm_subn_verify_config(IN osm_subn_opt_t * p_opts) log_report(" Invalid Cached Option Value:console = %s" ", Using Default:%s\n", p_opts->console, OSM_DEFAULT_CONSOLE); - p_opts->console = OSM_DEFAULT_CONSOLE; + p_opts->console = strdup(OSM_DEFAULT_CONSOLE);
If console is set to a wrong value, you get some memory leak here, because strdup() allocates new buffer and the old one is never free.
}
if (p_opts->qos) {
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html-- -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html