From: Randy Dunlap <hidden> Date: 2011-10-07 20:59:44
From: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
Add <linux/stat.h> to fix build errors:
drivers/infiniband/hw/ipath/ipath_init_chip.c:54:1: error: 'S_IRUGO' undeclared here (not in a function)
drivers/infiniband/hw/ipath/ipath_init_chip.c:54:1: error: bit-field '<anonymous>' width not an integer constant
drivers/infiniband/hw/ipath/ipath_init_chip.c:67:1: error: 'S_IWUSR' undeclared here (not in a function)
drivers/infiniband/hw/ipath/ipath_init_chip.c:67:1: error: bit-field '<anonymous>' width not an integer constant
Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
Cc: Mike Marciniszyn <redacted>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
drivers/infiniband/hw/ipath/ipath_init_chip.c | 1 +
1 file changed, 1 insertion(+)
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Roland Dreier <hidden> Date: 2011-10-07 21:21:43
On Fri, Oct 7, 2011 at 1:59 PM, Randy Dunlap [off-list ref] wrote:
Add <linux/stat.h> to fix build errors:
When did this break? I build ipath in my test config all the time...
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Stephen Rothwell <hidden> Date: 2011-10-07 23:28:23
Hi all,
On Fri, 07 Oct 2011 15:05:44 -0700 Randy Dunlap [off-list ref] wrote:
On 10/07/11 14:21, Roland Dreier wrote:
quoted
On Fri, Oct 7, 2011 at 1:59 PM, Randy Dunlap [off-list ref] wrote:
quoted
Add <linux/stat.h> to fix build errors:
When did this break? I build ipath in my test config all the time...
First I saw it was in today's linux-next (20111007).
Its probably associated with the module.h split up. But see Rule 1 in
Documentation/SubmitChecklist. Implicit inclusion of files can easily
break when built for a different architecture or config ...
--
Cheers,
Stephen Rothwell sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org
http://www.canb.auug.org.au/~sfr/
From: Mike Marciniszyn <hidden> Date: 2011-10-10 18:58:02
As do I.
I've confirmed that patch does no harm, but I would like to see the error.
Which of the github repos exposes the error?
Mike
-----Original Message-----
From: Roland Dreier [mailto:roland@purestorage.com]
Sent: Friday, October 07, 2011 5:21 PM
To: Randy Dunlap
Cc: Stephen Rothwell; linux-next@vger.kernel.org; linux-kernel;
Dept_Infinipath; linux-rdma@vger.kernel.org; Andrew Morton
Subject: Re: [PATCH -next] infiniband: fix ipath_chip_init.c build
errors
On Fri, Oct 7, 2011 at 1:59 PM, Randy Dunlap [off-list ref]
wrote:
quoted
Add <linux/stat.h> to fix build errors:
When did this break? I build ipath in my test config all the time...
- R.
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
From: Randy Dunlap <hidden> Date: 2011-10-10 19:02:25
On 10/10/11 11:57, Mike Marciniszyn wrote:
As do I.
I've confirmed that patch does no harm, but I would like to see the error.
Which of the github repos exposes the error?
I saw it in linux-next of 20111007.
Mike
quoted
-----Original Message-----
From: Roland Dreier [mailto:roland@purestorage.com]
Sent: Friday, October 07, 2011 5:21 PM
To: Randy Dunlap
Cc: Stephen Rothwell; linux-next@vger.kernel.org; linux-kernel;
Dept_Infinipath; linux-rdma@vger.kernel.org; Andrew Morton
Subject: Re: [PATCH -next] infiniband: fix ipath_chip_init.c build
errors
On Fri, Oct 7, 2011 at 1:59 PM, Randy Dunlap [off-list ref]
wrote:
quoted
Add <linux/stat.h> to fix build errors:
When did this break? I build ipath in my test config all the time...
- R.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
From: Mike Marciniszyn <hidden> Date: 2011-10-11 13:06:39
Add <linux/stat.h> to fix build errors:
drivers/infiniband/hw/ipath/ipath_init_chip.c:54:1: error: 'S_IRUGO'
undeclared here (not in a function)
drivers/infiniband/hw/ipath/ipath_init_chip.c:54:1: error: bit-field
'<anonymous>' width not an integer constant
drivers/infiniband/hw/ipath/ipath_init_chip.c:67:1: error: 'S_IWUSR'
undeclared here (not in a function)
drivers/infiniband/hw/ipath/ipath_init_chip.c:67:1: error: bit-field
'<anonymous>' width not an integer constant
Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
Thanks for the patch!
Acked-by: Mike Marciniszyn <redacted>
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html