Re: [patch v2 13/37] add rxe_verbs.c

On Mon, Aug 15, 2011 at 04:33:14PM +0200, Bart Van Assche wrote:

On Sun, Jul 24, 2011 at 9:43 PM,  [off-list ref] wrote:

quoted

+	for (i = 0; i < ARRAY_SIZE(rxe_dev_attributes); ++i) {
+		err = device_create_file(&dev->dev, rxe_dev_attributes[i]);
+		if (err) {
+			pr_warn("device_create_file failed, "
+				"i = %d, err = %d\n", i, err);
+			goto err2;
+		}
+	}

(added Greg in CC)

It's not your fault but loops similar to the above for creating device
attributes occur in many drivers in the Linux kernel. How about adding
functions called device_create_files() and device_remote_files()
functions in drivers/base/core.c ? If you want you can start from the
implementations of sysfs_create_files() and sysfs_remove_files() in
fs/sysfs/file.c.

How about using the api functions that are already present in the kernel
to do the exact thing you are asking for here?

And no one should EVER be doing a loop like the above mentioned one, so
yes, it is their fault :)

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html