Thread (5 messages) 5 messages, 4 authors, 2011-03-18
STALE5574d

[PATCH] rdma/addr: Initialize ret to fix build warning

From: Hefty, Sean <hidden>
Date: 2011-03-17 23:35:44
Also in: linux-next, lkml
Subsystem: infiniband subsystem, the rest · Maintainers: Jason Gunthorpe, Leon Romanovsky, Linus Torvalds

Commit b23dd4fe42b455af5c6e20966b7d6959fa8352ea (ipv4: Make output
route lookup return rtable directly) resulted in leaving
ret uninitialized, where it may later be returned.

Signed-off-by: Sean Hefty <redacted>
---
I didn't actually test this, but it looks correct.

 drivers/infiniband/core/addr.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
index e0ef5fd..4ffc224 100644
--- a/drivers/infiniband/core/addr.c
+++ b/drivers/infiniband/core/addr.c
@@ -204,7 +204,7 @@ static int addr4_resolve(struct sockaddr_in *src_in,
 
 	/* If the device does ARP internally, return 'done' */
 	if (rt->dst.dev->flags & IFF_NOARP) {
-		rdma_copy_addr(addr, rt->dst.dev, NULL);
+		ret = rdma_copy_addr(addr, rt->dst.dev, NULL);
 		goto put;
 	}
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help