Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics
From: Christoph Hellwig <hch@lst.de>
Date: 2024-06-11 05:52:44
Also in:
ceph-devel, dm-devel, linux-bcache, linux-block, linux-m68k, linux-mmc, linux-nvme, linux-s390, linux-scsi, linux-um, linuxppc-dev, nvdimm, virtualization, xen-devel
On Tue, Jun 11, 2024 at 02:51:24PM +0900, Damien Le Moal wrote:
quoted
- if (lim->zoned) + if (sdkp->device->type == TYPE_ZBC)Nit: use sd_is_zoned() here ?
Yes.
quoted
- if (!sd_is_zoned(sdkp)) + if (!sd_is_zoned(sdkp)) { + lim->zoned = false;Maybe we should clear the other zone related limits here ? If the drive is reformatted/converted from SMR to CMR (FORMAT WITH PRESET), the other zone limits may be set already, no ?
blk_validate_zoned_limits already takes care of that.