On Mon, Jun 10, 2024 at 08:19:33AM -0400, Martin K. Petersen wrote:

On the wire between controller and target there's only CRC. If I want to
write a "bad" CRC to disk, I have switch the controller to CRC mode. The
controller can't convert a "bad" IP checksum to a "bad" CRC. The PI test
tooling relies heavily on being able to write "bad" things to disk and
read them back to validate that we detect the error.

But how do you even toggle the flag?  There is no no code to do that.
And if you already have a special kernel module for that it really
should just use a passthrough request to take care of that.

Note that unlike the NOCHECK flag which I just cleaned up because they
were unused, this one actually does get in the way of the architecture
of the whole series :(  We could add a per-bip csum_type but it would
feel really weird.