Re: [PATCH] md: fix md_seq_ops() regressions
From: Song Liu <song@kernel.org>
Date: 2024-01-09 19:15:13
Also in:
lkml
From: Song Liu <song@kernel.org>
Date: 2024-01-09 19:15:13
Also in:
lkml
On Tue, Jan 9, 2024 at 5:43 AM Yu Kuai [off-list ref] wrote:
From: Yu Kuai <redacted>
Commit cf1b6d4441ff ("md: simplify md_seq_ops") introduce following
regressions:
1) If list all_mddevs is emptly, personalities and unused devices won't
be showed to user anymore.
2) If seq_file buffer overflowed from md_seq_show(), then md_seq_start()
will be called again, hence personalities will be showed to user
again.
3) If seq_file buffer overflowed from md_seq_stop(), seq_read_iter()
doesn't handle this, hence unused devices won't be showed to user.
Fix above problems by print personalities and unused devices in
md_seq_show(), as it used to be.
Fixes: cf1b6d4441ff ("md: simplify md_seq_ops")
Signed-off-by: Yu Kuai <redacted>Applied to md-6.8 branch. (Yes, I am trying to make some changes to the branches we use. ) Thanks, Song