Thread (20 messages) 20 messages, 6 authors, 2024-01-12

Re: [PATCH 0/3] md: Remove deprecated flavors

From: Song Liu <song@kernel.org>
Date: 2023-12-18 16:12:07
Also in: linux-block, lkml

Hi Mariusz,

On Mon, Dec 18, 2023 at 12:32 AM Mariusz Tkaczyk
[off-list ref] wrote:
[...]
quoted
quoted
Please note that there are mdadm tests for those levels. I can approve it
only when mdadm clean-up is merged. Our tests must pass continuously.
Is the continuous test result available publicly?
We are working on public CI (Paul owns it). On my side I'm not executing all
tests, IMSM only. In this case it is obvious that mdadm tests will stop passing,
I don't need results to see that. We should keep both mdadm and md compatible.
We are continuously adding new MD regression tests to mdadm (at least Kuai is
doing that) so we should also care about removing things.
quoted
quoted
It is a nice code complexity improvement so let me know if you would
like to get my help with mdadm patches.
On my local tests with mdadm, I need to make changes to the following
tests:

00linear...
00names...
00raid0...
00readonly...
02lineargrow...
03r0assem...
04r0update...
04update-metadata...

The changes are all straightforward (just remove things related to
linear/multipath/faulty).
Please do not forgot remove dead code from mdadm. For example simple find
"multipath" (case insensitive) reefers me to multiple places with special
handling for this level. We need to remove it from code and documentation.
Can you handle this too?
I think this is a bigger discussion: will mdadm stop supporting these
flavors on
older kernels? Say, mdadm-5.0+ (or a different number) will not support
multipath flavor on older kernels?
Oh and last one, I can't find update for md man in your changes. Could you
please remove those levels from md man?
man side is easier. Once we know which major will have this set (6.8 or later),
we can update the man pages with the information.

Thanks,
Song
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help