Thread (12 messages) 12 messages, 3 authors, 2023-11-28

Re: [PATCH v2 1/6] md: fix missing flush of sync_work

From: Song Liu <song@kernel.org>
Date: 2023-11-28 03:49:02
Also in: lkml

On Mon, Nov 27, 2023 at 6:07 PM Yu Kuai [off-list ref] wrote:
Hi,

在 2023/11/28 8:02, Song Liu 写道:
quoted
On Fri, Nov 24, 2023 at 12:00 AM Yu Kuai [off-list ref] wrote:
quoted
From: Yu Kuai <redacted>

Commit ac619781967b ("md: use separate work_struct for md_start_sync()")
use a new sync_work to replace del_work, however, stop_sync_thread() and
__md_stop_writes() was trying to wait for sync_thread to be done, hence
they should switch to use sync_work as well.

Noted that md_start_sync() from sync_work will grab 'reconfig_mutex',
hence other contex can't held the same lock to flush work, and this will
be fixed in later patches.

Fixes: ac619781967b ("md: use separate work_struct for md_start_sync()")
This fix should go via md-fixes branch. Please send it separately.
This patch alone is not good, there are follow up problems to be fixed
completely after patch 5. Can this patchset applied to md-fixes?

Or I can split patch 1,4 and 5 for md-fixes, and keep others to md-next.
Yes, please split the patches into two sets.

Thanks,
Song
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help