Thread (4 messages) 4 messages, 3 authors, 2023-09-25

Re: [PATCH] md: do not require mddev_lock() for all options

From: Song Liu <song@kernel.org>
Date: 2023-09-22 21:05:06

Hi Mariusz,

Sorry for the late reply.

On Wed, Sep 13, 2023 at 1:55 AM Mariusz Tkaczyk
[off-list ref] wrote:
We don't need to lock device to reject not supported request
in array_state_store().
Main motivation is to make a room for action does not require lock yet,
like prepare to stop (see md_ioctl()).
I made some changes to the commit log:

    md: do not require mddev_lock() for all options

    We don't need to lock device to reject not supported request
    in array_state_store().
    Main motivation is to make a room for action does not require lock yet,
    like prepare to stop (see md_ioctl()).

But I am not sure what you meant by "make a room for action does not
require lock yet". Could you please explain?

Otherwise, the code looks reasonable to me.

Thanks,
Song
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help