On Wed, Aug 23, 2023 at 10:09 PM Mariusz Tkaczyk
[off-list ref] wrote:

Hi Xiao,
some nits:

On Mon,  8 May 2023 21:30:10 +0800
Xiao Ni [off-list ref] wrote:

quoted

mdcheck_continue is triggered by mdcheck_start timer. It's used to
continue check action if the raid is too big and mdcheck_start
service can't finish check action. If mdcheck start can finish check
action, it doesn't need to mdcheck continue service anymore. So stop
it when mdcheck start service can finish check action.

Signed-off-by: Xiao Ni <redacted>
---
 misc/mdcheck | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/misc/mdcheck b/misc/mdcheck
index 700c3e252e72..f56972c8ed10 100644
--- a/misc/mdcheck
+++ b/misc/mdcheck

@@ -140,7 +140,13 @@ do
              echo $a > $fl
              any=yes
      done
-     if [ -z "$any" ]; then exit 0; fi
+     if [ -z "$any" ]; then
+             #mdcheck_continue.timer is started by mdcheck_start.timer.
+             #When he check action can be finished in

's/he/the/g'
I think that there should be space after '#' but it is preferred to use /* */
Could you please send v2?

Hi Mariusz

diff --git a/misc/mdcheck b/misc/mdcheck
index 700c3e252e72..f87999d3e797 100644
--- a/misc/mdcheck
+++ b/misc/mdcheck

@@ -140,7 +140,13 @@ do
                echo $a > $fl
                any=yes
        done
-       if [ -z "$any" ]; then exit 0; fi
+       # mdcheck_continue.timer is started by mdcheck_start.timer.
+       # When the check action can be finished in mdcheck_start.service,
+       # it doesn't need mdcheck_continue anymore.
+       if [ -z "$any" ]; then
+               systemctl stop mdcheck_continue.timer
+               exit 0;
+       fi
        sleep 120
 done

How about this one?

Regards
Xiao

Thanks,
Mariusz