On Fri 07-07-23 04:28:41, Christoph Hellwig wrote:

On Thu, Jul 06, 2023 at 06:14:33PM +0200, Jan Kara wrote:

quoted

quoted

struct bdev_handle *bdev_open_by_path(dev_t dev, blk_mode_t mode,
		void *holder, const struct blk_holder_ops *hops);
void bdev_release(struct bdev_handle *handle);

I'd maybe use bdev_close() instead of bdev_release() but otherwise I like
the new naming.

We're using release everywhese else, but if Jens is fine with that I
can live with close.

Dunno, to me words pair like open-close, get-put, acquire-release.
Furthermore e.g. ->release() (and thus blkdev_release()) is called only
when the last file reference is dropped, not when each reference is
dropped, so that's why bdev_release() seems a bit confusing to me.

								Honza

-- 
Jan Kara [off-list ref]
SUSE Labs, CR