Hi,

在 2023/07/06 21:01, Paul Menzel 写道:

Dear Yu,


Thank you for your patch. Some minor nits, if you are interested.

Am 06.07.23 um 09:16 schrieb Yu Kuai:

quoted

From: Yu Kuai <redacted>

There are four equivalent goto tags in raid_ctr(), clean them up to use
just one, there are no functional change and prepare to fix that

Maybe:

There *is* no functional change, and is a preparation to fix an 
unprotected `md_stop()`.

quoted

md_stop() is not protected.

In the commit message summary/title, I’d spell the verb with a space:

     Clean up four equivalent goto tags in raid_ctr()

Thanks for the suggestions, I'll update them in the next version.

Thanks,
Kuai

quoted

Signed-off-by: Yu Kuai <redacted>
---
  drivers/md/dm-raid.c | 27 +++++++++------------------
  1 file changed, 9 insertions(+), 18 deletions(-)

[…]


Kind regards,

Paul

.