Re: [PATCH v5 00/20] bio: check return values of bio_add_page
From: Johannes Thumshirn <hidden>
Date: 2023-05-05 08:09:38
Also in:
dm-devel, linux-block, linux-fsdevel, linux-mm
From: Johannes Thumshirn <hidden>
Date: 2023-05-05 08:09:38
Also in:
dm-devel, linux-block, linux-fsdevel, linux-mm
On 02.05.23 12:20, Johannes Thumshirn wrote:
We have two functions for adding a page to a bio, __bio_add_page() which is used to add a single page to a freshly created bio and bio_add_page() which is used to add a page to an existing bio. While __bio_add_page() is expected to succeed, bio_add_page() can fail. This series converts the callers of bio_add_page() which can easily use __bio_add_page() to using it and checks the return of bio_add_page() for callers that don't work on a freshly created bio. Lastly it marks bio_add_page() as __must_check so we don't have to go again and audit all callers. Changes to v4: - Rebased onto latest Linus' master - Dropped already merged patches - Added Sergey's Reviewed-by Changes to v3: - Added __bio_add_folio and use it in iomap (Willy) - Mark bio_add_folio must check (Willy) - s/GFS/GFS2/ (Andreas) Changes to v2: - Removed 'wont fail' comments pointed out by Song Changes to v1: - Removed pointless comment pointed out by Willy - Changed commit messages pointed out by Damien - Colledted Damien's Reviews and Acks
Jens any comments on this?