[PATCH 2/4] Fix memory leak in file Kill
From: miaoguanqin <hidden>
Date: 2023-03-23 01:33:32
Subsystem:
the rest · Maintainer:
Linus Torvalds
When we test mdadm with asan,we found some memory leaks in Kill.c We fix these memory leaks based on code logic. Signed-off-by: miaoguanqin <redacted> Signed-off-by: lixiaokeng <redacted> --- Kill.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/Kill.c b/Kill.c
index bfd0efdc..46a1a8a0 100644
--- a/Kill.c
+++ b/Kill.c@@ -41,6 +41,7 @@ int Kill(char *dev, struct supertype *st, int force, int verbose, int noexcl) * 4 - failed to find a superblock. */ + int flags = 0; int fd, rv = 0; if (force)
@@ -52,8 +53,10 @@ int Kill(char *dev, struct supertype *st, int force, int verbose, int noexcl) dev); return 2; } - if (st == NULL) + if (st == NULL) { st = guess_super(fd); + flags = 1; + } if (st == NULL || st->ss->init_super == NULL) { if (verbose >= 0) pr_err("Unrecognised md component device - %s\n", dev);
@@ -77,6 +80,10 @@ int Kill(char *dev, struct supertype *st, int force, int verbose, int noexcl) rv = 0; } } + if (flags == 1 && st) { + st->ss->free_super(st); + free(st); + } close(fd); return rv; }
--
2.33.0