Thread (47 messages) 47 messages, 5 authors, 2023-03-31

Re: [PATCH 13/19] zram: use __bio_add_page for adding single page to bio

From: Pankaj Raghav <hidden>
Date: 2023-03-31 12:28:52
Also in: dm-devel, linux-block, linux-btrfs, linux-fsdevel, linux-mm

On Wed, Mar 29, 2023 at 10:05:59AM -0700, Johannes Thumshirn wrote:
The zram writeback code uses bio_add_page() to add a page to a newly
created bio. bio_add_page() can fail, but the return value is never
checked.

Use __bio_add_page() as adding a single page to a newly created bio is
guaranteed to succeed.

This brings us a step closer to marking bio_add_page() as __must_check.

Signed-off-by: Johannes Thumshirn <redacted>
Looks good,
Reviewed-by: Pankaj Raghav <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help