Re: [PATCH] Grow: fix can't change bitmap type from none to clustered.
From: Jes Sorensen <hidden>
Date: 2023-02-23 18:24:12
From: Jes Sorensen <hidden>
Date: 2023-02-23 18:24:12
On 2/23/23 09:39, Heming Zhao wrote:
Commit a042210648ed ("disallow create or grow clustered bitmap with writemostly set") introduced this bug. We should use 'true' logic not '== 0' to deny setting up clustered array under WRITEMOSTLY condition. How to trigger~/mdadm # ./mdadm -Ss && ./mdadm --zero-superblock /dev/sd{a,b} ~/mdadm # ./mdadm -C /dev/md0 -l mirror -b clustered -e 1.2 -n 2 \ /dev/sda /dev/sdb --assume-clean mdadm: array /dev/md0 started. ~/mdadm # ./mdadm --grow /dev/md0 --bitmap=none ~/mdadm # ./mdadm --grow /dev/md0 --bitmap=clustered mdadm: /dev/md0 disks marked write-mostly are not supported with clustered bitmapSigned-off-by: Heming Zhao <redacted>
Applied! Thanks, Jes