Thread (10 messages) 10 messages, 4 authors, 2023-02-23

Re: [PATCH v3 3/3] md: Use optimal I/O size for last bitmap page

From: Reindl Harald <hidden>
Date: 2023-02-22 23:49:14


Am 23.02.23 um 00:42 schrieb Christoph Hellwig:
On Wed, Feb 22, 2023 at 02:58:28PM -0700, Jonathan Derrick wrote:
quoted
+	if (io_size != opt_size &&
+	    start + opt_size / SECTOR_SIZE <= boundary)
+		return opt_size;
+	else if (start + io_size / SECTOR_SIZE <= boundary)
No need for an else after a return.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
the "return" is within the if-condition and has nothing to do with the 
else - with {} it would be clearly visible
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help