Re: [PATCH] block: remove bio_set_op_attrs
From: Christoph Hellwig <hch@lst.de>
Date: 2022-12-06 14:51:03
Also in:
dm-devel, linux-bcache, linux-block
On Tue, Dec 06, 2022 at 10:46:31PM +0800, Coly Li wrote:
BTW, may I ask why bio_set_op_attrs() is removed. Quite long time ago it was added to avoid open code, and now we remove it to use open coded assignments. What is the motivation for now?
It was added when the flags encoding was a mess. Now that the RQF_ flags are split out things have become much simpler and we don't need to hide a simple assignment of a value to a field.