On 9/22/22 07:21, Kusiak, Mateusz wrote:

On 14/09/2022 17:03, Coly Li wrote:

quoted

quoted

2022年8月18日 22:56，Mateusz Kusiak [off-list ref] 写道：

[snipped]

quoted

@@ -628,29 +659,15 @@ static int update_super0(struct supertype *st, struct mdinfo *info,

		sb->disks[info->disk.number].minor = info->disk.minor;
		sb->disks[info->disk.number].raid_disk = info->disk.raid_disk;
		sb->disks[info->disk.number].state = info->disk.state;
-	} else if (strcmp(update, "resync") == 0) {
-		/* make sure resync happens */
+		break;
+	case UOPT_RESYNC:
+		/**
+		 *make sure resync happens
+		 */

The above change doesn’t follow existing code style for comments. How about using the previous one line version?

Personaly, I'd rather change it from "/**" to "/*". I think we should
gradually adapt the code to kernel coding style.
Are you fine with that?

Kernel style is good, but that would be either

/* foo comment */

or

/*
 * bar comment
 */

Thanks,
Jes

quoted

[snipped]

Thanks.

Coly Li