Re: [PATCH 9/9] udev: Move udev_block() and udev_unblock() into udev.c

[PATCH 0/9] Mdmonitor refactor and udev event handling improvements · Mateusz Grzonka <hidden> · 2022-09-07
[PATCH 1/9] Mdmonitor: Split alert() into separate functions · Mateusz Grzonka <hidden> · 2022-09-07
Re: [PATCH 1/9] Mdmonitor: Split alert() into separate functions · Coly Li <hidden> · 2022-10-28
Re: [PATCH 1/9] Mdmonitor: Split alert() into separate functions · Jes Sorensen <hidden> · 2022-12-28
[PATCH 2/9] Mdmonitor: Make alert_info global · Mateusz Grzonka <hidden> · 2022-09-07
Re: [PATCH 2/9] Mdmonitor: Make alert_info global · Coly Li <hidden> · 2022-10-28
Re: [PATCH 2/9] Mdmonitor: Make alert_info global · Jes Sorensen <hidden> · 2022-12-28
Re: [PATCH 2/9] Mdmonitor: Make alert_info global · Grzonka, Mateusz <hidden> · 2023-01-19
[PATCH 3/9] Mdmonitor: Pass events to alert() using enums instead of strings · Mateusz Grzonka <hidden> · 2022-09-07
Re: [PATCH 3/9] Mdmonitor: Pass events to alert() using enums instead of strings · Coly Li <hidden> · 2022-10-28
[PATCH 4/9] Mdmonitor: Add helper functions · Mateusz Grzonka <hidden> · 2022-09-07
Re: [PATCH 4/9] Mdmonitor: Add helper functions · Coly Li <hidden> · 2022-10-28
[PATCH 5/9] Add helpers to determine whether directories or files are soft links · Mateusz Grzonka <hidden> · 2022-09-07
Re: [PATCH 5/9] Add helpers to determine whether directories or files are soft links · Coly Li <hidden> · 2022-10-28
[PATCH 6/9] Mdmonitor: Refactor write_autorebuild_pid() · Mateusz Grzonka <hidden> · 2022-09-07
Re: [PATCH 6/9] Mdmonitor: Refactor write_autorebuild_pid() · Coly Li <hidden> · 2022-10-28
[PATCH 7/9] Mdmonitor: Refactor check_one_sharer() for better error handling · Mateusz Grzonka <hidden> · 2022-09-07
Re: [PATCH 7/9] Mdmonitor: Refactor check_one_sharer() for better error handling · Coly Li <hidden> · 2022-10-28
[PATCH 8/9] Mdmonitor: Improve udev event handling · Mateusz Grzonka <hidden> · 2022-09-07
Re: [PATCH 8/9] Mdmonitor: Improve udev event handling · Coly Li <hidden> · 2022-10-28
[PATCH 9/9] udev: Move udev_block() and udev_unblock() into udev.c · Mateusz Grzonka <hidden> · 2022-09-07
Re: [PATCH 9/9] udev: Move udev_block() and udev_unblock() into udev.c · Paul Menzel <hidden> · 2022-09-07
Re: [PATCH 9/9] udev: Move udev_block() and udev_unblock() into udev.c · Coly Li <hidden> · 2022-10-28
Re: [PATCH 0/9] Mdmonitor refactor and udev event handling improvements · Coly Li <hidden> · 2022-10-28

From: Paul Menzel <hidden>
Date: 2022-09-07 13:21:19

Dear Mateusz,


Thank you for your patches.

Am 07.09.22 um 14:56 schrieb Mateusz Grzonka:

Add kernel style comments and better error handling.

Please add a note, why the move is useful even if `lib.c` was just used 
for historic reasons.

Change-Id: Ib6b8e7725d6739a2d7f7b8801e3403137c9cc402

The tag seems to be a leftover – or share the Gerrit URL.

[…]


Kind regards,

Paul

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help