Thread (15 messages) 15 messages, 4 authors, 2022-07-20

Re: fix md disk_name lifetime problems v4

From: Logan Gunthorpe <logang@deltatee.com>
Date: 2022-07-19 18:44:52
Also in: linux-block


On 2022-07-19 12:42, Song Liu wrote:
On Tue, Jul 19, 2022 at 2:18 AM Christoph Hellwig [off-list ref] wrote:
quoted
Hi all,

this series tries to fix a problem repored by Logan where we see
duplicate sysfs file name in md.  It is due to the fact that the
md driver only checks for duplicates on currently live mddevs,
while the sysfs name can live on longer.  It is an old problem,
but the race window got longer due to waiting for the device freeze
earlier in del_gendisk.

Changes since v3:
 - remove a now superflous mddev->gendisk NULL check
 - use a bit in mddev->flags instead of a new field

Changes since v2:
 - delay mddev->kobj initialization

Changes since v1:
 - rebased to the md-next branch
 - fixed error handling in md_alloc for real
 - add a little cleanup patch
Applied to md-next. Thanks!
I've only just finished my testing on this and it all looks good to me.

I've also reviewed the last 2 patches, for what it's worth.

Logan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help