Re: [PATCH] udev-md-raid-assembly.rules: skip if DM_UDEV_DISABLE_OTHER_RULES_FLAG
From: NeilBrown <hidden>
Date: 2022-02-16 22:09:49
Also in:
dm-devel
On Thu, 17 Feb 2022, mwilck@suse.com wrote:
From: Martin Wilck <redacted> device-mapper sets the flag DM_UDEV_DISABLE_OTHER_RULES_FLAG to 1 for devices which are unusable. They may be no set up yet, suspended, or otherwise unusable (e.g. multipath maps without usable path). This flag does not necessarily imply SYSTEMD_READY=0 and must therefore be tested separately.
I really don't like this - looks like a hack. A Kludge. Can you provide a reference to a detailed discussion that explains why SYSTEMD_READY=0 cannot be used? Thanks, NeilBrown
quoted hunk ↗ jump to hunk
Signed-off-by: Martin Wilck <redacted> --- udev-md-raid-assembly.rules | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/udev-md-raid-assembly.rules b/udev-md-raid-assembly.rules index d668cdd..4568b01 100644 --- a/udev-md-raid-assembly.rules +++ b/udev-md-raid-assembly.rules@@ -21,6 +21,11 @@ IMPORT{cmdline}="noiswmd" IMPORT{cmdline}="nodmraid" ENV{nodmraid}=="?*", GOTO="md_inc_end" + +# device mapper sets DM_UDEV_DISABLE_OTHER_RULES_FLAG for devices which +# aren't ready to use +KERNEL=="dm-*", ENV{DM_UDEV_DISABLE_OTHER_RULES_FLAG}=="1", GOTO="md_inc_end" + ENV{ID_FS_TYPE}=="ddf_raid_member", GOTO="md_inc" ENV{noiswmd}=="?*", GOTO="md_inc_end" ENV{ID_FS_TYPE}=="isw_raid_member", ACTION!="change", GOTO="md_inc"-- 2.35.1