Re: [PATCH 2/2] raid5: introduce MD_BROKEN
From: Song Liu <song@kernel.org>
Date: 2021-09-24 21:18:46
On Fri, Sep 17, 2021 at 8:35 AM Mariusz Tkaczyk [off-list ref] wrote:
Raid456 module had allowed to achieve failed state, distinct from other
redundant levels. It was fixed by fb73b357fb9 ("raid5: block failing
device if raid will be failed").
This fix introduces a bug, now if raid5 fails during IO, it may result
with a hung task without completion.It will be great if we can add repro steps and/or hung stack trace here.
Faulty flag on the device is
necessary to process all requests and is checked many times, mainly in
anaylze_stripe().
Allow to set faulty flag on drive again and set MD_BROKEN if raid is
failed.
Fixes: fb73b357fb9 ("raid5: block failing device if raid will be failed")
Signed-off-by: Mariusz Tkaczyk <redacted>For both patches, please provide more information about what is being fixed and describe the behavior. Thanks, Song