Re: [PATCH 09/15] bcache: use bvec_virt
From: Coly Li <hidden>
Date: 2021-08-04 17:05:21
Also in:
ceph-devel, dm-devel, linux-bcache, linux-block, linux-nvme, linux-s390, linux-scsi, linux-um
On 8/4/21 5:56 PM, Christoph Hellwig wrote:
Use bvec_virt instead of open coding it. Note that the existing code is fine despite ignoring bv_offset as the bio is known to contain exactly one page from the page allocator per bio_vec. Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me. Reviewed-by: Coly Li <redacted> Thanks. Coly Li
quoted hunk ↗ jump to hunk
--- drivers/md/bcache/btree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c index 183a58c89377..0595559de174 100644 --- a/drivers/md/bcache/btree.c +++ b/drivers/md/bcache/btree.c@@ -378,7 +378,7 @@ static void do_btree_node_write(struct btree *b) struct bvec_iter_all iter_all; bio_for_each_segment_all(bv, b->bio, iter_all) { - memcpy(page_address(bv->bv_page), addr, PAGE_SIZE); + memcpy(bvec_virt(bv), addr, PAGE_SIZE); addr += PAGE_SIZE; }