Thread (4 messages) flat view 4 messages, 2 authors, 2021-03-04

Re: resend: [PATCH v2 mdadm] super1.c: avoid useless sync when bitmap switches from clustered to none

From: heming.zhao@suse.com <hidden>
Date: 2021-03-03 01:20:00

On 3/2/21 4:35 PM, heming.zhao@suse.com wrote:
quoted hunk ↗ jump to hunk
With kernel commit 480523feae58 ("md: only call set_in_sync() when it
is expected to succeed."), mddev->in_sync in clustered array is always
zero. It makes metadata resync_offset to always zero.
When assembling a clusterd array with "-U no-bitmap" option, kernel
md layer "mddev->resync_offset == 0" and "mddev->bitmap == NULL" will
trigger raid1 do sync on every bitmap chunk. the sync action is useless,
... ...
---
v2: only set MaxSector on bitmap clean device

---
  super1.c | 2 ++
  1 file changed, 2 insertions(+)
diff --git a/super1.c b/super1.c

Hello all,

more info:
This patch had been verified & run in SUSE customer env for some time.

Thanks,
Heming
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help