Thread (2 messages) flat view 2 messages, 2 authors, 2021-02-26

Re: [PATCH mdadm] Grow: be careful of corrupt dev_roles list

From: Jes Sorensen <hidden>
Date: 2021-02-26 22:22:14

On 2/25/21 8:02 PM, NeilBrown wrote:
I've seen a case where the dev_roles list of a linear array
was corrupt.  ->max_dev was > 128 and > raid_disks, and the
extra slots were '0', not 0xFFFE or 0xFFFF.

This caused problems when a 128th device was added.

So:
 1/ make Grow_Add_device more robust so that if numbers
   look wrong, it fails-safe.

 2/ make examine_super1() report details if the dev_roles
   array is corrupt.

Signed-off-by: NeilBrown <redacted>
---
 Grow.c   | 15 ++++++++++++---
 super1.c | 48 ++++++++++++++++++++++++++++++++++++++----------
 2 files changed, 50 insertions(+), 13 deletions(-)
Ohhh error handling!

Applied!

Thanks,
Jes

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help