Thread (2 messages) 2 messages, 2 authors, 2020-11-03

Re: [PATCH 06/11] md: implement ->set_read_only to hook into BLKROSET processing

From: Christoph Hellwig <hch@lst.de>
Date: 2020-11-03 09:32:54
Also in: ceph-devel, linux-bcache, linux-block, linux-s390

On Tue, Nov 03, 2020 at 12:19:34AM +0000, James Troup wrote:
Christoph Hellwig [off-list ref] writes:
quoted
@@ -7809,6 +7778,36 @@ static int md_compat_ioctl(struct block_device *bdev, fmode_t mode,
[...]
quoted
+	 * Transitioning to readauto need only happen for arrays that call
+	 * md_write_start and which are not ready for writes yet.
I realise you're just moving the comment around but perhaps you could
s/readauto/readonly/ while you're doing so?
readonly doesn't make sense here as we transition away from read-only.
MD seems to have a read-auto mode, although it usually is spelled with
the dash, so I'll switch this comment to use the more common spelling.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help